This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
Reduce number of reallocations #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 82.68% 82.55% -0.14%
==========================================
Files 13 13
Lines 1057 1026 -31
==========================================
- Hits 874 847 -27
+ Misses 183 179 -4
☔ View full report in Codecov by Sentry. |
hratoanina
approved these changes
Oct 10, 2023
| @@ -521,7 +521,8 @@ pub struct DKGParticipantList<C: CipherSuite> { | |||
| impl<C: CipherSuite> DistributedKeyGeneration<RoundOne, C> { | |||
There was a problem hiding this comment.
Random question, but if the to_bytes function is identical for a DistributedKeyGeneration<RoundTwo, _>, can't you implement both at the same time?
There was a problem hiding this comment.
Yes to_bytes / from_bytes could be defined for an arbitrary DkgState, I didn't bother dealing with it because we may refactor this, following #8. But that's acknowledged, thanks for noticing 👍🏼
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-allocate sufficient amounts when creating new vectors, most of the time relying on the
compressed_size()method from theCanonicalSerializetrait.Mostly useful for
to_bytesmethods. Some vector initializations are purposedly left untouched, either because they are within unit tests or because they deal with malicious participants which, we hope at least, wouldn't require more than 1 allocation in the worst case (i.e. at most 4 malicious participants at once).PR Checklist: